Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

 ឵឵  #5763

Closed
wants to merge 3 commits into from
Closed

Conversation

I-am-TURBO
Copy link
Contributor

Description:

The button just calls the normal fishing contest command with no location option causing the bot to to respond you need so many of bait to fish at location instead of checking if you have items for the other location

i updated the fishingContestStartCommand() function to check for the items of both locations

all-in-all this will get rid of having to manually send the command for the location you do have items for.

mad thanks to @themrrobert for this.

Changes:

  • changed if (!loc)... to iterate over all validLoc items putting current value in location
  • changed (user.bank.has(location.fishing_location)) to (user.bank.amount(location.bait.id)

Other checks:

  • I have tested all my changes thoroughly.

@I-am-TURBO I-am-TURBO marked this pull request as draft March 8, 2024 19:09
@I-am-TURBO I-am-TURBO closed this Mar 8, 2024
@I-am-TURBO I-am-TURBO deleted the fish_contest_button branch March 8, 2024 19:33
@I-am-TURBO I-am-TURBO changed the title Updated fishing contest button to check for the items of both locations  ឵឵  Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant